Add codegenConfig
to package.json
to prevent generating duplicate classes
#506
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like codegen will generate duplicated files if
codegenConfig
property is missing frompackage.json
(meaning all view manager delegates and interfaces will be also generated underreact-native-mmkv/android/build/generated/source/codegen/react/viewmanagers
). This results in the build failing due to multiple definitions of the same classes.I'm not exactly sure what
jsSrcsDir
should point to in this case. It doesn't really matter as long as the library doesn't depend on the generated code, but if it points to a non-existent directory the build will fail. Since files undersrc
aren't included in the npm package, I figured thelib/module
will do. Feel free to change it if you have other ideas.Related issue: software-mansion/react-native-gesture-handler#2382