iOS: Also compile from source (don't use CocoaPods MMKV dependency, but rather use git submodule MMKV/) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9784023.
mrousavy
added
enhancement
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Android uses the
MMKV/folder (a git submodule) and builds MMKV from source, it would make sense to let the iOS version also do that to maintain the same version (same commit) across platforms.I had some issues with copying over the MMKV/Core and MMKV/iOS folder since that made cocoapods "produce duplicate UUIDs".
Now I will try to only use the MMKV/Core library, basically create my own wrapper just like Tencent/MMKV/iOS did.
I'm having build issues with Objective-C ARC rn, hopefully someone can help here.