Fix/webinar service and controller

src/api/controllers/Webinar.controller.ts

@@ -39,15 +39,20 @@ export const getWebinarById = async (
   response: Response,
   next: NextFunction
 ) => {
-  await WebinarService.fetchWebinarById(request.params.webinarId)
-    .then((data) => {
-      request.handleResponse.successRespond(response)(data);
-      next();
-    })
-    .catch((error: any) => {
-      request.handleResponse.errorRespond(response)(error.message);
-      next();
-    });
+  let webinarId = request.params.webinarId;
+  if (webinarId) {
+    await WebinarService.fetchWebinarById(request.params.webinarId)
+      .then((data) => {
+        request.handleResponse.successRespond(response)(data);
+        next();
+      })
+      .catch((error: any) => {
+        request.handleResponse.errorRespond(response)(error.message);
+        next();
+      });
+  } else {
+    request.handleResponse.errorRespond(response)("WebinarId not found");
+  }
 };
 /**
  * @todo implement a @function getWebinars that calls
@@ -135,15 +140,20 @@ export const updateWebinar = async (
   response: Response,
   next: NextFunction
 ) => {
-  await WebinarService.updateWebinar(request.params.webinarId, request.body)
-    .then((data) => {
-      request.handleResponse.successRespond(response)(data);
-      next();
-    })
-    .catch((error: any) => {
-      request.handleResponse.errorRespond(response)(error.message);
-      next();
-    });
+  let webinarId = request.params.webinarId;
+  if (webinarId) {
+    await WebinarService.updateWebinar(request.params.webinarId, request.body)
+      .then((data) => {
+        request.handleResponse.successRespond(response)(data);
+        next();
+      })
+      .catch((error: any) => {
+        request.handleResponse.errorRespond(response)(error.message);
+        next();
+      });
+  } else {
+    request.handleResponse.errorRespond(response)("WebinarId not found");
+  }
 };
 /**
  * @todo implement a @function deleteWebinar that calls
@@ -159,13 +169,18 @@ export const deleteWebinar = async (
   response: Response,
   next: NextFunction
 ) => {
-  await WebinarService.removeWebinar(request.params.webinarId)
-    .then((data) => {
-      request.handleResponse.successRespond(response)(data);
-      next();
-    })
-    .catch((error: any) => {
-      request.handleResponse.errorRespond(response)(error.message);
-      next();
-    });
+  let webinarId = request.params.webinarId;
+  if (webinarId) {
+    await WebinarService.removeWebinar(request.params.webinarId)
+      .then((data) => {
+        request.handleResponse.successRespond(response)(data);
+        next();
+      })
+      .catch((error: any) => {
+        request.handleResponse.errorRespond(response)(error.message);
+        next();
+      });
+  } else {
+    request.handleResponse.errorRespond(response)("WebinarId not found");
+  }
 };

src/api/services/Webinar.service.ts

@@ -2,72 +2,78 @@ import { DocumentDefinition, FilterQuery } from "mongoose";
 import { IWebinar } from "../interfaces";
 import WebinarModel from "../models/Webinar.model";
 /**
- * @todo create @function insertWebinar to save a webinar in the database
+ * Save a webinar in the database
+ * @param {IWebinar} webinarData
+ * @returns {IWebinar} New webinar document
  */
 export const insertWebinar = async (
   webinarData: DocumentDefinition<IWebinar>
 ) => {
   return await WebinarModel.create(webinarData)
-    .then(async (webinar) => {
+    .then((webinar) => {
       return webinar;
     })
     .catch((error) => {
       throw new Error(error.message);
     });
 };
 /**
- * @todo create @function fetchWebinarById to fetch a webinar in the system
+ * Fetch a webinar in the database
  * @param webinarId @type string
+ * @returns {IWebinar} Webinar document for relevent ID
  */
 export const fetchWebinarById = async (webinarId: string) => {
   return await WebinarModel.findById(webinarId)
-    .then(async (webinar) => {
+    .then((webinar) => {
       return webinar;
     })
     .catch((error) => {
       throw new Error(error.message);
     });
 };
 /**
- * @todo create @function fetchWebinars to fetch all the webinars in the system
+ * Fetch all the webinars in the database
+ * @returns {IWebinar} All webinar documents in the database
  */
 export const fetchWebinars = async () => {
-  return await WebinarModel.find()
-    .then(async (webinars) => {
+  return await WebinarModel.aggregate([{ $match: { deletedAt: { $eq: null } } }])
+    .then((webinars) => {
       return webinars;
     })
     .catch((error) => {
       throw new Error(error.message);
     });
 };
 /**
- * @todo create @function fetchPastWebinars to fetch all the past webinars in the system
+ * Fetch all the past webinars in the database
+ * @returns {IWebinar} All the past webinar documents in the database
  */
 export const fetchPastWebinars = async () => {
   return await WebinarModel.find({ webinarType: "PAST" })
-    .then(async (webinars) => {
+    .then((webinars) => {
       return webinars;
     })
     .catch((error) => {
       throw new Error(error.message);
     });
 };
 /**
- * @todo create @function fetchUpcomingWebinar to fetch an upcoming webinars in the system
+ * Fetch an upcoming webinars in the database
+ * @returns {IWebinar} All the upcoming webinar documents in the database
  */
 export const fetchUpcomingWebinar = async () => {
   return await WebinarModel.findOne({ webinarType: "UPCOMING" })
     .limit(1)
     .sort({ $natural: -1 })
-    .then(async (webinar) => {
+    .then((webinar) => {
       return webinar;
     })
     .catch((error) => {
       throw new Error(error.message);
     });
 };
 /**
- * @todo create @function updateWebinar to update a webinar in the system
+ * Update a webinar in the database
  * @param webinarId @type string
  * @param updateData @type DocumentDefinition<IWebinar>
  */
@@ -95,7 +101,7 @@ export const updateWebinar = async (
     });
 };
 /**
- * @todo create @function removeWebinar to delete a webinar
+ * Delete a webinar in the database
  * @param webinarId @type string
  */
 export const removeWebinar = async (webinarId: string) => {