Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed a bug which could cause a crash in HeaderParser, and as consequence could potentially crash a web server based on it #22

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Removed a bug which could cause a crash in HeaderParser, and as consequence could potentially crash a web server based on it #22

wants to merge 5 commits into from
+25 −38

Commits on Aug 10, 2021

  1. removed bug caused by uninitialized variable h in function HeaderPars… 

    …er.prototype._parseHeader
    @RolandHeinze
    RolandHeinze committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    b7fca2e View commit details
    Browse the repository at this point in the history

  2. removed unnecessary code in funvtion 

    HeaderParser.prototype._parseHeader
    @RolandHeinze
    RolandHeinze committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    dbf3bfa View commit details
    Browse the repository at this point in the history

  3. the value of end was calculated incorrectly in 

    constructor function HeaderParser.
In the case of start > 0, end would be wrong.
    @RolandHeinze
    RolandHeinze committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    6549a54 View commit details
    Browse the repository at this point in the history

  4. removed variable _realFinish in 

    constructor function Dicer and all its occurances,
as it is not necessary, increases the code size,
and adds unwanted complexity.
    @RolandHeinze
    RolandHeinze committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    cba4d3c View commit details
    Browse the repository at this point in the history

  5. removed unnecessary else if clause in function Dicer.prototype._oninfo. 

    The else if clause was exactly the opposite of the if clause.
    @RolandHeinze
    RolandHeinze committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    8003224 View commit details
    Browse the repository at this point in the history