Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CausalEffectsMatrix in SCM #157

Merged
merged 16 commits into from
Sep 3, 2024

Conversation

JorgeLuizFranco
Copy link
Collaborator

We want to given a vector of features(where number of features = number of nodes in the causal graph) $x$ create a decoded vector $x_{\text{decoded}}$ that has new values corresponding to the causal effects of its parents + bias. In this sense, we want to create a matrix to encode this matrix in such a way that:

$x_{\text{decoded}} = A x$

In this case, $A = \text{CausalEffectsMatrix}$ is the matrix that stores the causal equations of the SCM.

@mschauer
Copy link
Owner

Here you are changing the interface? I had a bit of a feeling that the interface wasn't ripe yet, but did not want to bother you yet. But in future, let's be more careful about not breaking the API needlessy. There is also a "conflict", can you check?

@JorgeLuizFranco
Copy link
Collaborator Author

Here you are changing the interface? I had a bit of a feeling that the interface wasn't ripe yet, but did not want to bother you yet. But in future, let's be more careful about not breaking the API needlessy. There is also a "conflict", can you check?

Sorry, @mschauer . I think I don't get what you mean as "interface". Could you clarify? Going to check the conflicts

@mschauer
Copy link
Owner

Maybe this helps? https://www.youtube.com/watch?v=q3qE2nJRuYM

test/equations.jl Outdated Show resolved Hide resolved
Co-authored-by: Moritz Schauer <moritzschauer@web.de>
@JorgeLuizFranco JorgeLuizFranco merged commit ee4de8a into mschauer:master Sep 3, 2024
6 checks passed
@JorgeLuizFranco JorgeLuizFranco deleted the scm/equations branch September 3, 2024 15:57
@JorgeLuizFranco
Copy link
Collaborator Author

@mschauer I forgot to ask, but we need to place @JuliaRegistrator register in the commit comment to register the package, right? Also update de Project.toml with this new version.

@JuliaRegistrator
Copy link

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

@mschauer
Copy link
Owner

mschauer commented Sep 3, 2024

Yes, can you prepare a minor version bump to the project as pull request?

@JorgeLuizFranco
Copy link
Collaborator Author

Yes, can you prepare a minor version bump to the project as pull request?

Sure, @mschauer I can prepare it. Which number should I insert in version? 16.0.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants