Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace codecov with coveralls #837

Closed
wants to merge 1 commit into from
Closed

replace codecov with coveralls #837

wants to merge 1 commit into from

Conversation

ygj6
Copy link
Collaborator

@ygj6 ygj6 commented Feb 2, 2020

  • Replace codecov with coveralls

It works for my repo. But I'm not sure whether it works for the msgpack repo.

  • Install dependencies in the folders outside the workspace

The reports generated by coveralls will include dependencies if the dependencies are installed inside the workspace . So I installed gtest to /usr/local/ and boost to ~/boost/.
Why not install boost to /usr/local/? The actions/cache has no permission to do it.

  • Extract function (installing gtest) into a script (gtest.sh)

@ygj6 ygj6 changed the title replace codecov wiith coveralls replace codecov with coveralls Feb 2, 2020
@ygj6
Copy link
Collaborator Author

ygj6 commented Feb 2, 2020

The reports of coveralls is here:
https://coveralls.io/github/msgpack/msgpack-c

@redboltz
Copy link
Contributor

redboltz commented Feb 4, 2020

I created #838 to test on msgpack repository.

@redboltz
Copy link
Contributor

redboltz commented Feb 4, 2020

I think that the coverage data uploaded successfully.
See
https://coveralls.io/builds/28513840

But when I tried to see the file coverage, I got 500 error.
For example clieck TREE include/msgpack/v3/parse.hpp, then I got error.
I guess that this is a way to check file level coverage.

Could you try this?

@ygj6
Copy link
Collaborator Author

ygj6 commented Feb 4, 2020

Ok, I will look at it soon.

@ygj6
Copy link
Collaborator Author

ygj6 commented Feb 4, 2020

20200204161237
I can open the file include/msgpack/v3/parse.hpp.
Have you signed in to coveralls with your github account?

@redboltz
Copy link
Contributor

redboltz commented Feb 4, 2020

I didn't sign in. I tried sing in, then I got the result.
It is a little confusing that I can see the directory tree without sign in but I can't see the code without sign in.

I think that it is acceptable because someone who want to know the detail of coverage, they usually have github account.

@redboltz
Copy link
Contributor

redboltz commented Feb 4, 2020

15 hours ago, codecov started to implement tokenless uploading functionality.

See

codecov/codecov-action#29 (comment)
https://community.codecov.io/t/whitelist-github-action-servers-to-upload-without-a-token/491/15

@ygj6 , I respect your work for coveralls, but I'm more familiar with codecov. I'd like to wait a little more to decide which one should be used.

@ygj6
Copy link
Collaborator Author

ygj6 commented Feb 4, 2020

It's a good news. In fact, I prefer the user interface of codecov.
Do you think these two parts are useful? If yes, I will resubmit them after fixing the codecov

  • Install dependencies in the folders outside the workspace
  • Extract function (installing gtest) into a script (gtest.sh).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants