Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "-target:jvm-1.7" from scalacOptions #456

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Feb 7, 2018

Scala 2.12 does not support "-target:jvm-1.7"

Scala 2.12 does not support "-target:jvm-1.7"
@xerial
Copy link
Member

xerial commented Feb 7, 2018

OK. Then we need to drop java7 support totally in upcoming version.

@komamitsu @frsyuki
Should we bump the version number to 0.9.x before dropping Java7 support?

@xuwei-k
Copy link
Contributor Author

xuwei-k commented Feb 8, 2018

msgpack-java already use sbt 1.x (which does not support Java 7)

@xerial
Copy link
Member

xerial commented Feb 8, 2018

@xuwei-k I'm not sure how sbt handles target:jvm-1.7 option, but msgpack-core-0.8.14.jar still built for JVM7 (class version 0.51):

javap -cp . -v "org.msgpack.core.MessagePack" | grep version                                                                     [11:24:44 Feb 07 2018]
  minor version: 0
  major version: 51

@xuwei-k
Copy link
Contributor Author

xuwei-k commented Feb 9, 2018

but msgpack-core-0.8.14.jar still built for JVM7 (class version 0.51):

Yes, sbt 1.x can generate JVM7 byte code from Java sources. but sbt 1.x and Scala 2.12 compiler does not run on JVM 7.
This pull request changes scalacOptions not javacOptions. scalacOptions is different from javacOptions.
This change has no effect (just suppress warnings) because Scala 2.12 compiler says follows when set -target:jvm-1.7

[warn] -target is deprecated: -target:jvm-1.7 is deprecated, forcing use of jvm-1.8

@xerial
Copy link
Member

xerial commented Feb 9, 2018

@xuwei-k Thanks for making it clear. I got confused scalacOptions and javacOptions.

@xerial xerial merged commit 33ce348 into msgpack:develop Feb 9, 2018
@xerial
Copy link
Member

xerial commented Feb 9, 2018

Merged.

@xuwei-k xuwei-k deleted the patch-1 branch February 9, 2018 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants