Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessagePackFactory should add getFormatName for naming the factory #515

Merged
merged 1 commit into from
Nov 10, 2019
Merged

MessagePackFactory should add getFormatName for naming the factory #515

merged 1 commit into from
Nov 10, 2019

Conversation

qxo
Copy link
Contributor

@qxo qxo commented Nov 3, 2019

No description provided.

@xerial xerial requested a review from komamitsu November 9, 2019 01:09
komamitsu
komamitsu approved these changes Nov 10, 2019
View reviewed changes
Copy link
Member

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@komamitsu komamitsu merged commit ba61279 into msgpack:develop Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komamitsu komamitsu komamitsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qxo @komamitsu