Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom context for keeping track of objects #101

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

grantila
Copy link
Contributor

This resolved #98

@codecov-io
Copy link

Codecov Report

Merging #101 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   98.54%   98.55%   +<.01%     
==========================================
  Files          15       15              
  Lines         896      901       +5     
  Branches      188      188              
==========================================
+ Hits          883      888       +5     
  Misses         13       13
Impacted Files Coverage Δ
src/encode.ts 100% <100%> (ø) ⬆️
src/Encoder.ts 97.85% <100%> (ø) ⬆️
src/decode.ts 100% <100%> (ø) ⬆️
src/ExtensionCodec.ts 100% <100%> (ø) ⬆️
src/decodeAsync.ts 100% <100%> (ø) ⬆️
src/Decoder.ts 99.13% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908d093...38ad537. Read the comment docs.

* Custom user-defined data, read/writable
*/
context: ContextType;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These utilities sound really great 👍

@gfx
Copy link
Member

gfx commented Jan 14, 2020

Thank you! Sound perfect.

@gfx gfx merged commit f31c55d into msgpack:master Jan 14, 2020
@gfx
Copy link
Member

gfx commented Jan 14, 2020

I will release a new version later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contextual state shared across encode/decode
3 participants