Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forceIntegerToFloat option for integers #123

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Add forceIntegerToFloat option for integers #123

merged 2 commits into from
Sep 21, 2020

Conversation

carbotaniuman
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2020

Codecov Report

Merging #123 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files          15       15           
  Lines         929      930    +1     
  Branches      198      199    +1     
=======================================
+ Hits          915      916    +1     
  Misses         14       14           
Impacted Files Coverage Δ
src/encode.ts 100.00% <ø> (ø)
src/Encoder.ts 97.98% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bbe3a9...257deaf. Read the comment docs.

@gfx
Copy link
Member

gfx commented Sep 20, 2020

ref. #122

Thanks for the PR. The code looks good to me, but I'm not sure whether the name forceFloat is best. I mean, it really looks like forceFloat32, but the behavior is completely different. I'd like to find a better name, for example forceIntegerToFloat. Any idea?

@gfx
Copy link
Member

gfx commented Sep 21, 2020

Thanks!

@gfx gfx merged commit f4a0c27 into msgpack:master Sep 21, 2020
@gfx gfx changed the title Add forceFloat option for integers Add forceIntegerToFloat option for integers Sep 21, 2020
@gfx
Copy link
Member

gfx commented Sep 21, 2020

Released v2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants