Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop IE11 support & no env access for Deno #221

Merged
merged 6 commits into from
Mar 3, 2023
Merged

Drop IE11 support & no env access for Deno #221

merged 6 commits into from
Mar 3, 2023

Conversation

gfx
Copy link
Member

@gfx gfx commented Mar 3, 2023

  • Assumes TextEncoder exists (AFAIK IE11 is the only engine that does not support TextEncoder as of 2023)
  • DataView always throws RangeError for its out of bounds except for IE11

close #219

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Patch coverage: 96.42% and project coverage change: +0.17 🎉

Comparison is base (bd0db9c) 98.14% compared to head (f1f96e4) 98.31%.

❗ Current head f1f96e4 differs from pull request most recent head 2f07cec. Consider uploading reports for the commit 2f07cec to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   98.14%   98.31%   +0.17%     
==========================================
  Files          16       16              
  Lines         968      952      -16     
  Branches      206      193      -13     
==========================================
- Hits          950      936      -14     
+ Misses         18       16       -2     
Impacted Files Coverage Δ
src/Decoder.ts 99.16% <85.71%> (-0.01%) ⬇️
src/Encoder.ts 97.94% <100.00%> (-0.06%) ⬇️
src/utils/utf8.ts 96.87% <100.00%> (+1.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gfx gfx merged commit daae51c into main Mar 3, 2023
@gfx gfx deleted the gfx/no-ie11 branch March 3, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: option to disable TEXT_ENCODING env check
2 participants