Add decodeStream #46
Merged
Add decodeStream #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyzenchenko
force-pushed
the
decodeStream
branch
from
d100436
to
059dbff
Compare
…ecodeStream # Conflicts: # src/decodeAsync.ts
gfx
reviewed
May 30, 2019
src/Decoder.ts
Outdated
|
|
||
| try { | ||
| while (true) { | ||
| let result = this.decodeSync(); |
There was a problem hiding this comment.
Suggested change
| let result = this.decodeSync(); | |
| const result = this.decodeSync(); |
gfx
reviewed
May 30, 2019
| for await (let item of decoder.decodeArrayStream(stream)) { | ||
| yield item; | ||
| } | ||
| return decoder.decodeArrayStream(stream); |
gfx
reviewed
May 30, 2019
test/decodeStream.test.ts
Outdated
|
|
||
| const result = []; | ||
|
|
||
| for await (let item of decodeStream(createStream())) { |
There was a problem hiding this comment.
Suggested change
| for await (let item of decodeStream(createStream())) { | |
| for await (const item of decodeStream(createStream())) { |
|
fixed @gfx |
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=========================================
Coverage ? 93.45%
=========================================
Files ? 15
Lines ? 840
Branches ? 175
=========================================
Hits ? 785
Misses ? 29
Partials ? 26
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.