Add support for numbers as map keys #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyzenchenko
commented
Aug 30, 2019
| @@ -12,10 +12,18 @@ const enum State { | |||
| MAP_VALUE, | |||
| } | |||
|
|
|||
| type MapKeyType = string | number; | |||
|
|
|||
| const isValidMapKeyType = (key: unknown): key is MapKeyType => { | |||
There was a problem hiding this comment.
Maybe we don't need this function and I can just put it into if. It just looks better :)
This function should not affect performance because it's very small and will be inlined
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 98.33% 98.33% +<.01%
==========================================
Files 16 16
Lines 959 962 +3
Branches 194 195 +1
==========================================
+ Hits 943 946 +3
Misses 16 16
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.