Lazily allocate and eagerly free unpacker stack #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applications may have numerous unpacker instances allocated with different configurations, but are very unlikely to have more than one or a handful active concurrently. As such eagerly allocating the 4kiB parsing stack is using more memory than necessary. Additionally, when only a few arena pages are in use, allocating a chunk from a first page is very cheap. The only complexity in this patch is the `Unpacker#each` API that requires not to free the stack on EOF as parsing may be resumed afterwards.
casperisfine
force-pushed
the
lazy-allocate-stack
branch
from
1d82c85
to
8506279
Compare
byroot
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications may have numerous unpacker instances allocated with different configurations, but are very unlikely to have more than one or a handful active concurrently.
As such eagerly allocating the 4kiB parsing stack is using more memory than necessary.
Additionally, when only a few arena pages are in use, allocating a chunk from a first page is very cheap.
The only complexity in this patch is the
Unpacker#eachAPI that requires not to free the stack on EOF as parsing may be resumed afterwards.@peterzhu2118