Update ROUTER_IP env #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msh100
requested changes
Feb 26, 2023
There was a problem hiding this comment.
Thanks for this! I had no idea that this was still displayed. To be honest, I'd ultimately like to get rid of the environments, they're just a bit awkward.
Can you revert the example change though? I don't think having the example in Docker makes much sense since Docker is more of an addition to the repo
| -e INFLUX_URL=http://influxdb:8086 \ | ||
| -e INFLUX_DB=modem-stats \ | ||
| -e FETCH_INTERVAL=1 \ | ||
| msh100/modem-stats |
There was a problem hiding this comment.
I'd rather not change this, but instead, make it work again.
It should be something like
go run main.go --modem=superhub3 --ip=192.168.100.1
|
I believe the issue with #4 is simply down to a newer version of InfluxDB, the image doesn't support that (and maybe should!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the headstart here, it seems to me the readme is behind now?
It still might be a little behind with these changes I'm proposing; I'm not sure if:
--ip=x.x.x.x)go run sh-stats/*.go --modem=superhub3 --ip=192.168.100.1Changes here get it a little closer to running, I believe I'm just using the latest version of influxdb and running into #4
Will see about adding support for that next.