dovecot: when testing, find an installed curl or install (#593)

Fixes #592

include/mua.sh

@@ -42,9 +42,18 @@ EOF
 
 test_imap_curl()
 {
-	# shellcheck disable=SC2001
-	curl -k -v --login-options 'AUTH=PLAIN' \
-		"imaps://$(uriencode $MUA_TEST_USER):$(uriencode $MUA_TEST_PASS)@${MUA_TEST_HOST}/"
+	local _test_uri
+	_test_uri="imaps://$(uriencode $MUA_TEST_USER):$(uriencode $MUA_TEST_PASS)@${MUA_TEST_HOST}/"
+
+	if [ -x /usr/local/bin/curl ]; then
+		curl -k -v --login-options 'AUTH=PLAIN' "$_test_uri"
+	elif [ -x "$STAGE_MNT/usr/local/bin/curl" ]; then
+		_test_uri="imaps://$(uriencode $MUA_TEST_USER):$(uriencode $MUA_TEST_PASS)@localhost/"
+		stage_exec curl -k -v --login-options 'AUTH=PLAIN' "$_test_uri"
+	else
+		pkg install -y curl
+		curl -k -v --login-options 'AUTH=PLAIN' "$_test_uri"
+	fi
 }
 
 test_imap()

provision/dovecot.sh

@@ -324,27 +324,20 @@ configure_tls_certs()
 
 	local _ssldir="$ZFS_DATA_MNT/dovecot/etc/ssl"
 	if [ ! -d "$_ssldir/certs" ]; then
-		mkdir -p "$_ssldir/certs"
-		chmod 644 "$_ssldir/certs"
+		# shellcheck disable=SC2174
+		mkdir -m 644 -p "$_ssldir/certs"
 	fi
 
 	if [ ! -d "$_ssldir/private" ]; then
-		mkdir "$_ssldir/private"
-		chmod 644 "$_ssldir/private"
+		mkdir -m 0644 "$_ssldir/private"
 	fi
 
 	local _installed_crt="$_ssldir/certs/${TOASTER_MAIL_DOMAIN}.pem"
-	if [ -f "$_installed_crt" ]; then
-		tell_status "dovecot TLS certificates already installed"
-		return
+	if [ ! -f "$_installed_crt" ]; then
+		tell_status "installing dovecot TLS certificates"
+		cp /etc/ssl/certs/server.crt "$_ssldir/certs/${TOASTER_MAIL_DOMAIN}.pem"
+		cp /etc/ssl/private/server.key "$_ssldir/private/${TOASTER_MAIL_DOMAIN}.pem"
 	fi
-
-	tell_status "installing dovecot TLS certificates"
-	cp /etc/ssl/certs/server.crt "$_ssldir/certs/${TOASTER_MAIL_DOMAIN}.pem"
-	# sunset after Dovecot 2.3 released
-	cat /etc/ssl/dhparam.pem >> "$_ssldir/certs/${TOASTER_MAIL_DOMAIN}.pem"
-	# /sunset
-	cp /etc/ssl/private/server.key "$_ssldir/private/${TOASTER_MAIL_DOMAIN}.pem"
 }
 
 configure_postfix_with_sasl()