Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BungeeCord #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BungeeCord #154

wants to merge 1 commit into from

Conversation

Goblom
Copy link

@Goblom Goblom commented Apr 29, 2013

With the release of BungeeCord, MSM because uncompatible. MSM is
uncompatible because of the "stop" command being hardcoded into MSM.
BungeeCord uses 'end' instead of 'stop', this fixes that.

/* WARNING */ NOT TESTED, BUT WORKS IN THERY

With the release of BungeeCord, MSM because uncompatible. MSM is
uncompatible because of the "stop" command being hardcoded into MSM.
BungeeCord uses 'end' instead of 'stop', this fixes that.

/* WARNING */ NOT TESTED, BUT WORKS IN THERY
@Goblom
Copy link
Author

Goblom commented Apr 29, 2013

Note: Sometimes has trouble detecting if server_is_running

Server server.properties has to be like this otherwise it wont run at all

  • msm-version=bungeecord/1.0
  • msm-invocation=java -Xss192k -Xmx1G -jar {JAR}
  • msm-log=proxy.log.0

@Goblom Goblom mentioned this pull request May 22, 2013
IronTetsubo added a commit to IronTetsubo/minecraft-server-manager that referenced this pull request Jun 11, 2013
@IronTetsubo
Copy link
Contributor

I merged your patch into my repo, but there were some issues (you were using server_eval instead of server_command, and you "fixed" a reference to stop that should have stayed the same), see the commit above. That should do the trick. I haven't actually tried bungeecord yet, that's next, but the base minecraft server should now work with both our commits.

@IronTetsubo
Copy link
Contributor

this is actually a bigger issue than your patch - there's a bunch of changes needed to get bungeecord fully supported. I have some of the pieces but not all, and I'll keep feeding them back as pull requests as mine are accepted. I don't remember the full list, but another one is abstracting out LOG_REGEX since bungeecord uses a different syntax.

@AnthonyAMC
Copy link

Bungeecord support would be a great addition!

@BrainStone
Copy link

BrainStone commented Apr 11, 2017

@IronTetsubo can you make your fix a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants