Two chains in the same file #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When two chains are in one file, the chains are defined only to the module level, resulting in a KeyError. By including the chain variable name in the endpoint prefix, this resolves the issue.
Fixed issue causing two chains in one file to fail
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
|
Thx for the patch @kevroy314 ! Apologies for the delay |
msoedov
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed this issue: #21 as described and tested. Works fine.
One thing to consider is if you want the "." character to delimit the chain name from the module. I think it's fine, but another character that won't cause problems might be warranted.