Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add _afterRemoveVault hook to SameAssetsUnderlyingAVbstractVault #69

Merged
merged 4 commits into from
Nov 3, 2022
Merged

add _afterRemoveVault hook to SameAssetsUnderlyingAVbstractVault #69

merged 4 commits into from
Nov 3, 2022

Conversation

tushargargght
Copy link
Contributor

@tushargargght tushargargght commented Nov 2, 2022 •
edited
Loading

Linked to #68

  • Added _afterRemoveVault hook to SameAssetsUnderlyingAbstractVault
  • Consumed above hook in PeriodicAllocationAbstractVault to update assetsPerShare
  • unit-test for the scenario

@tushargargght tushargargght self-assigned this Nov 2, 2022
@tushargargght tushargargght added contract Contract work v2 mStable v2 roadmap labels Nov 2, 2022
@tushargargght tushargargght linked an issue Nov 2, 2022 that may be closed by this pull request
add _afterRemoveVault hook to SameAssetsUnderlyingAVbstractVault #68
Closed
@naddison36
Copy link
Contributor

Looks good. Can you also run

sol2uml .. -hl -hi -d 1 -b PeriodicAllocationAbstractVault -i abis,artifacts,types,_flat,build

@tushargargght
Copy link
Contributor Author

Looks good. Can you also run

sol2uml .. -hl -hi -d 1 -b PeriodicAllocationAbstractVault -i abis,artifacts,types,_flat,build

done

@tushargargght tushargargght merged commit 8262554 into develop Nov 3, 2022
@tushargargght tushargargght deleted the issue/68-afterRemoveVault-hook branch November 3, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naddison36 naddison36 naddison36 approved these changes

Assignees

@tushargargght tushargargght

Labels
contract Contract work v2 mStable v2 roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add _afterRemoveVault hook to SameAssetsUnderlyingAVbstractVault
2 participants
@tushargargght @naddison36