New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for nil marshalable pointers #1

Merged

mstoykov merged 1 commit into mstoykov:master from joanlopez:fix-marshal

Apr 4, 2024

joanlopez commented Apr 4, 2024

Currently, if there is any custom type (type ...) that:

isn't represented by an underlying struct (e.g. type Custom uint8 or even type Custom2 Custom)
implements any of the supported marshaleable interfaces (either encoding.TextUnmarshaler or encoding.BinaryUnmarshaler)
and is defined in the config specification passed to envconfig.Process(...) as a (nil) pointer (zero value for pointers)

The processing fails: either panics (depends on the implementation) or just doesn't assign the value to the receiver.


          Fix support for nil marshalable pointers

f5be74b

joanlopez mentioned this pull request

Add NullSystemTagSet to correctly read K6_SYSTEM_TAGS from env grafana/k6#3660

Closed

5 tasks

mstoykov approved these changes

View reviewed changes

mstoykov merged commit 29baae8 into mstoykov:master

joanlopez mentioned this pull request

Update 'envconfig' to fix environment variables reads grafana/k6#3672

Merged

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet