Feature branch update for berlinger integration #2421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r TemperatureBreachRowType
…_sensor crate Include breach type in config description so that it's unique
Matching breach can have different end timestamp; matching config doesn't depend on is_active
Using updated temperature-sensor crate
…before adding the logs & breaches!
…anch-update-for-berlinger-integration
Bundle size differenceComparing this PR to
|
This was referenced Nov 2, 2023
|
I've update #2383 from this branch so closing |
mark-prins
reviewed
Nov 2, 2023
| @@ -4426,6 +4426,7 @@ export type SensorNode = { | |||
| }; | |||
|
|
|||
| export enum SensorNodeType { | |||
| Berlinger = 'BERLINGER', | |||
There was a problem hiding this comment.
😄 I added this in another PR and then removed it! ( taking the minimalist approach.. don't add code that we aren't using and I didn't need it anymore! )
Glad to see that it's back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry no issue, see description below for reference
I need to add upload functionality as per this issue: #2420, which required merge for feature branch into this PR: #1798.
Wanted to do this separately, to make it easier to review next PR.
This PR is just: #1798 updated from cold chain feature branch.
Had to re-instate temperature config repo and migrations, also update graphql schema.