fix: support throwing Response.error()
#563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
commented
Apr 21, 2024
| 'received network error response, erroring request...' | ||
| ) | ||
|
|
||
| this.errorWith(new TypeError('Network error')) |
There was a problem hiding this comment.
This is the only difference with the RequestError. Response.error supports no error message and so it's translated to a generic Network error error.
kettanaito
changed the title
Response.error()
kettanaito
commented
Apr 21, 2024
| @@ -119,7 +127,7 @@ export function createXMLHttpRequestProxy({ | |||
| mockedResponse.statusText | |||
| ) | |||
|
|
|||
| if (mockedResponse.type === 'error') { | |||
There was a problem hiding this comment.
Oops! Inaccessible way to check for Response.error().
|
This is a bug fix so I will merge this straight away. |
Released: v0.28.4 🎉This has been released in v0.28.4! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, throwing a
Response.erorr()will fall through theinstanceof Responsecheck and be used as a mocked response. That would actually thrown an error.Now, we have an extra check for thrown responses, if they are a
Response.error(), it will result in the network error (i.e. request error) just as it does if you dorequest.respondWith(Response.error()).