Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependency): unpin the "chalk" dependency #1639

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

blowery
Copy link
Contributor

@blowery blowery commented Jun 13, 2023

Open up the chalk dependency, which is currently pinned. This allows packages that use msw to choose the best, compatible chalk version without duplicating it in their module tree.

Note this PR does not update the lockfile. Running pnpm install using the pnpm@8.6.2 changed the lockfile version, which seemed like too big a change for this PR. The maintainer should update the lockfile in the best method for the project.

Open up the chalk dependency, which is currently pinned. This allows packages that use msw to choose
the best, compatible chalk version without duplicating it in their module tree.
@kettanaito
Copy link
Member

Hi, @blowery. Thanks for proposing this. I believe we've pinned chalk for some reason in the past. I will give this a try and see if setting a more permissive version range breaks anything.

Regarding pnpm, the massive diff you saw was due to the project using pnpm v7, not v8. I will make sure to update the lockfile.

@kettanaito
Copy link
Member

The chalk dependency seems to have been pinned in https://github.com/mswjs/msw/pull/1016/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L73. I don't see any comment there explaining why that was necessary, so it might've been an accident. Running the tests locally.

@kettanaito kettanaito changed the title build(dependency): Unpin the chalk dependency chore: unpin the "chalk" dependency Aug 22, 2023
Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves look good. Local testing confirmed that everything is functional. Let's wait for the remote testing to confirm that as well before merging.

@kettanaito kettanaito changed the title chore: unpin the "chalk" dependency fix(dependency): unpin the "chalk" dependency Aug 22, 2023
@kettanaito kettanaito merged commit a93f63b into mswjs:main Aug 22, 2023
9 checks passed
@kettanaito
Copy link
Member

@blowery, if I may, are you using MSW in Automatic?

@blowery
Copy link
Contributor Author

blowery commented Aug 22, 2023

@kettanaito yup! i don't think any of the usages are open source just yet though.

@blowery blowery deleted the unpin-chalk branch August 22, 2023 13:08
@kettanaito
Copy link
Member

@blowery, could you point me to the right person to contact if I'd like to feature the logos of the projects you're using MSW in? We currently do so with Google, Spotify and Microsoft, but the list of awesome companies I want to highlight on the next website has grown quite a bit since then :)

@kettanaito
Copy link
Member

Released: v1.2.4 🎉

This has been released in v1.2.4!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants