-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dependency): unpin the "chalk" dependency #1639
Conversation
Open up the chalk dependency, which is currently pinned. This allows packages that use msw to choose the best, compatible chalk version without duplicating it in their module tree.
Hi, @blowery. Thanks for proposing this. I believe we've pinned Regarding pnpm, the massive diff you saw was due to the project using pnpm v7, not v8. I will make sure to update the lockfile. |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes themselves look good. Local testing confirmed that everything is functional. Let's wait for the remote testing to confirm that as well before merging.
@blowery, if I may, are you using MSW in Automatic? |
@kettanaito yup! i don't think any of the usages are open source just yet though. |
@blowery, could you point me to the right person to contact if I'd like to feature the logos of the projects you're using MSW in? We currently do so with Google, Spotify and Microsoft, but the list of awesome companies I want to highlight on the next website has grown quite a bit since then :) |
Released: v1.2.4 🎉This has been released in v1.2.4! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Open up the chalk dependency, which is currently pinned. This allows packages that use msw to choose the best, compatible chalk version without duplicating it in their module tree.
Note this PR does not update the lockfile. Running
pnpm install
using thepnpm@8.6.2
changed the lockfile version, which seemed like too big a change for this PR. The maintainer should update the lockfile in the best method for the project.