fix: update @bundled-es-modules/cookie to 2.0.1
#2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
commented
Oct 10, 2024
| const cookies: Record<string, string> = {} | ||
|
|
||
| for (const cookieName in parsedCookies) { | ||
| if (typeof parsedCookies[cookieName] !== 'undefined') { |
There was a problem hiding this comment.
Account for cookie@1.0 annotating the parsing result as Record<string, string | undefined>. Skip the cookies with undefined values.
marklai1998
approved these changes
Oct 10, 2024
|
I've opened a PR to the bundled cookie package to have release automation to release fixes faster. bundled-es-modules/cookie#4 |
5 tasks
4 tasks
kettanaito
changed the title
cookie directly@bundled-es-modules/cookie to 2.0.1
|
The fix has been released in |
Released: v2.6.2 🎉This has been released in v2.6.2! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cookiepackage #2308Blockers
@bundled-es-modules/cookieonce Bump cookie dependency to ^0.7.1 bundled-es-modules/cookie#3 is released.