Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache installer in the toolcache #147

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Conversation

jeremyd2019
Copy link
Member

@jeremyd2019 jeremyd2019 commented Jul 5, 2021

Some concern about caching the entire install, but this should at least save self-hosted runners having to download the installer every run.

Enhancement for #145

main.js Show resolved Hide resolved
main.js Outdated Show resolved Hide resolved
main.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@eine eine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove the Fixes #145 from the main message. This is an enhancement related to #145, but as we discussed there, we want to allow caching the packages and/or the whole installation locally; not only the installer.

@eine eine merged commit 6f7a24a into msys2:master Jul 6, 2021
@jeremyd2019 jeremyd2019 deleted the toolcache-installer branch July 6, 2021 00:42
@jeremyd2019
Copy link
Member Author

Unfortunately, this is not working as intended. It seems that the date is not passing the check of a valid semver, and causing the toolcache to not find any version. Stupid thing.

@eine
Copy link
Collaborator

eine commented Jul 16, 2021

@jeremyd2019 do you need a new release of this action (since #148 was merged)?

@jeremyd2019
Copy link
Member Author

Not personally. I've moved to using release: false to reuse the msys2 install on my self-hosted runner, I just have to remember to install it manually when setting up the runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants