cache: conditionally disable the install cache, unset by default #63
Conversation
For some reason it sometimes loses files. It's not clear where the error is, so let's disable for now. Fixes msys2#61
|
Alternatively we could check if all files are there at some point to pin down where the error happens. |
|
I think this PR is ok as a temporal solution. The logic is not removed, but just conditionally disabled. Anyway, I believe it might be worth reporting this to GitHub. Maybe we can enhance our logic to track down when is it happening. But they might be able to detect it in their infrastructure too. |
eine
changed the title
|
I can't really rule out that the problem isn't on our side, even though I don't know what it could be. |
|
Is the error consistent? I mean, is it fixed by restarting a job? |
|
I haven't restarted the same job, but followup commits failed as well I think. |
|
The above two jobs show it perfectly (ctrl+f the cache IDs in them). Either it didn't save the files properly, or didn't restore it properly, or any of our commands after the restore removed it (but in this case there was no update, so this should in theory be a noop) |
For some reason it sometimes loses files. It's not clear where the error
is, so let's disable for now.
Fixes #61