Add support for the case that RDoc is installed as a default gem #1
+291
−270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
force-pushed
the
add-rubygems-hook-default-gem
branch
from
b61bc5d to
e88ba9c
Compare
mterada1228
reviewed
Nov 6, 2024
mterada1228
reviewed
Nov 6, 2024
mterada1228
reviewed
Nov 6, 2024
lib/rdoc/rubygems_hook.rb
Outdated
|
|
||
| def self.generation_hook installer, specs; end | ||
| # Generate document for compatibility if this is a default gem. | ||
| RubyGemsHook.generation_hook(installer, specs) |
There was a problem hiding this comment.
RubyGemsHook class doesn't have the generation_hook method.
Should you call RubyGemsHook.generate?
Suggested change
| RubyGemsHook.generation_hook(installer, specs) | |
| ::RDoc::RubyGemsHook.generate(installer, specs) |
There was a problem hiding this comment.
I've applied the suggested change but can we remove the ::RDoc:: part to simplify this code?
There was a problem hiding this comment.
I made mistake, sorry...
I think ::RDoc is unnecessary too.
Co-authored-by: mterada1228 <49284339+mterada1228@users.noreply.github.com>
|
@mterada1228 Thanks! You're right! All of them are applied. |
kou
commented
Nov 7, 2024
mterada1228
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Thanks! LGTM!
I merged this branch to https://github.com/mterada1228/rdoc/tree/add-rubygems-hook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.