Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using bootstrapped runtimes, add package.include to deployable zip file #49

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

alexanderwink
Copy link
Contributor

If there were package.include specified for a function that used a bootstrapped runtime the includes would simply be ignored. This PR will add the includes to the zip-file and ensure that they are deployed alongside the binary.

@lphuctai
Copy link

Hi @mthenw
I see you were fix this issue before in #40
But in the case of buildProvidedRuntimeAsBootstrap = true
It will return like this
return { individually: true, artifact: zipPath, };
This does not include property here, and makes the extension crash when we're trying to access it
packageConfig.include = packageConfig.include.concat( this.serverless.service.functions[name].package.include );

So this pull request completely fixes it!

@mthenw mthenw merged commit 0f5c4cf into mthenw:master Apr 4, 2024
@mthenw
Copy link
Owner

mthenw commented Apr 4, 2024

I'm gonna release new version later today or tomorrow.

@mthenw
Copy link
Owner

mthenw commented Apr 4, 2024

@alexanderwink @lphuctai new version (2.4.0) released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants