fix: prevent container functions from being processed as Go handlers #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the issue where containerized functions were incorrectly handled as Go handlers during the deploy/package process. The fix ensures that container functions are appropriately identified and processed separately.
mthenw
reviewed
Jul 30, 2024
|
Thank you for that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #54
Changes
Fixed an issue where containerized functions were incorrectly treated as Go handlers. This fix ensures that container functions are properly identified and no longer processed as Go handlers.
Issue Details
During deployment or packaging, containerized functions were sometimes mistakenly treated as Go handlers. This resulted in handlers being undefined, causing the go build command to fail and generate errors.
Testing
In the test environment, the go build command is not actually executed, so the error does not reproduce. However, in the production environment, the go build command fails and generates errors.