Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jbang and gav output formats #306

Closed
wants to merge 1 commit into from

Conversation

maxandersen
Copy link

would be nice having jbang and pure gav coordinate output support - so I made a PR exactly that :)

Copy link
Owner

@mthmulders mthmulders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution! I appreciate you took the effort to add this.

Only two small formatting-related changes, please. I will soon add something like Spotless so the formatting should no longer have to be part of PR discussions.

Oh, and could you please rebase against main? One of the build jobs that now fails should've been there. The mutation testing job is something I can't get to work for PR's yet, unfortunately, but that one shouldn't be blocking.

@@ -1,13 +1,13 @@
package it.mulders.mcs.cli;

import java.util.concurrent.Callable;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert the reordering of imports?

@@ -1,18 +1,21 @@
package it.mulders.mcs.search;

import java.util.Arrays;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert the reordering of imports?

@mthmulders mthmulders closed this in 4b84a0c May 7, 2024
@mthmulders
Copy link
Owner

@all-contributors please add @maxandersen for idea, code.

Copy link
Contributor

@mthmulders

I've put up a pull request to add @maxandersen! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants