toplevel.pl: fix arity mismatch in read_input/2 #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into the same problem today and I figured I'd take a stab at it. Unfortunately, I'm not certain it is the right approach, but it no longer errors like it did before. Fixes mthom#2650. Signed-off-by: Stephan Renatus <stephan@styra.com>
|
Damn, I missed this in #2527. I confirm that this is indeed the intended way that this should be fixed, good catch! |
|
Actually, this is not enough. If you press p and then Enter it does not end the query as it should. I'm not sure how to fix this. |
For my understanding: that is because the branch for |
Signed-off-by: Stephan Renatus <stephan@styra.com>
|
Pushed another commit. I think this is closer to the desired behaviour -- it's now "committing" to "continue" much later, only for the explicit "next" input... |
Signed-off-by: Stephan Renatus <stephan@styra.com>
bakaq
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the same problem today and I figured I'd take a stab at it. Unfortunately, I'm not certain it is the right approach, but it no longer errors like it did before.
Fixes #2650.