PR Feedback #55

Sammy1Am · 2024-08-10T18:32:49Z

No default names
Use time_id
Don't depend on climate
Break out sensor, binary_sensor, text_sensor, select, and button into their own directories
Convert sensors and selects into listeners to avoid needing AUTO_LOAD
List of temperature sensors moved to temperature_source select component (this simplifies the code since the climate-hub doesn't actually need a whole list of temperature sources, just the name of the current one)
Preferences to store last temperature source moved to temperature_source select component

…TemperatureSourceSelect

Sammy1Am added 11 commits August 8, 2024 20:51

No default name, use time_id, don't depend on climate

992f999

Break out sensors into sensor.py

f083124

Check for sensor nullptrs if not defined

371f77c

Breakout button into its own py file and directory

71a3296

Breakout select into directory/py file (temp sources not yet working)

2f33cdb

Fix temperature sources

a2794b3

Fix some formatting and test issues

0845cb6

Convert sensors to listeners

6ba7e17

Split up binary and text sensors, minor reorg to simplify config python

71ca436

Converted select to listener, moved preferences and source list into …

703ae88

…TemperatureSourceSelect

Lint and testing fixes

edeeec3

Sammy1Am requested a review from KazWolfe as a code owner August 10, 2024 18:32

More CI fixes

7208313

Sammy1Am merged commit dcac9bf into dev Aug 10, 2024
56 checks passed

Sammy1Am deleted the sensor-listeners branch August 12, 2024 17:29

Provide feedback