Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: include tokens usage for streamed output" #4336

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

mudler
Copy link
Owner

@mudler mudler commented Dec 8, 2024

Reverts #4282

See: #4334

Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit e407fd4
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/6755bb404c874900081a45c0
😎 Deploy Preview https://deploy-preview-4336--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mudler
Copy link
Owner Author

mudler commented Dec 8, 2024

ping @mintyleaf - seems the changeset blocks the server from serving further requests, I'm going to revert and tag a patch release until you can provide a fix quicker than me :)

@mudler mudler merged commit f943c4b into master Dec 8, 2024
28 of 31 checks passed
@mudler mudler deleted the revert-4282-fix/stream_tokens_usage branch December 8, 2024 16:53
@mintyleaf
Copy link
Contributor

ping @mintyleaf - seems the changeset blocks the server from serving further requests, I'm going to revert and tag a patch release until you can provide a fix quicker than me :)

really strange, bc i tested it locally on that examplish small phi2 model on arm64 mac and there is no issues with multiple requests to it

you really sure that my changeset causing this / able to reproduce that behavior?

@mudler
Copy link
Owner Author

mudler commented Dec 9, 2024

ping @mintyleaf - seems the changeset blocks the server from serving further requests, I'm going to revert and tag a patch release until you can provide a fix quicker than me :)

really strange, bc i tested it locally on that examplish small phi2 model on arm64 mac and there is no issues with multiple requests to it

you really sure that my changeset causing this / able to reproduce that behavior?

yep tested myself and was able to reproduce the behavior, reverting this changeset fixed it here. I've tested directly in the LocalAI WebUI: to reproduce you have to run subsequent messages in the chat and it will stall indefinetly

@mintyleaf
Copy link
Contributor

ping @mintyleaf - seems the changeset blocks the server from serving further requests, I'm going to revert and tag a patch release until you can provide a fix quicker than me :)

really strange, bc i tested it locally on that examplish small phi2 model on arm64 mac and there is no issues with multiple requests to it
you really sure that my changeset causing this / able to reproduce that behavior?

yep tested myself and was able to reproduce the behavior, reverting this changeset fixed it here. I've tested directly in the LocalAI WebUI: to reproduce you have to run subsequent messages in the chat and it will stall indefinetly

can you say which model you used?
still can't reproduce that web ui behavior with phi-2.Q2_K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants