Change default output & add WithTTY option #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
default-output
branch
from
7d4a513 to
2f39c0a
Compare
aymanbagabas
changed the title
muesli
reviewed
Mar 6, 2023
aymanbagabas
force-pushed
the
default-output
branch
from
8c686a5 to
cb66b65
Compare
|
The only thing I still dislike here is that we now have: |
Yes, this can get confusing :/ What do you suggest we name them instead? |
|
Renamed to |
muesli
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default global output.
Add a WithTTY option to assume tty output
Fixes: #105
Fixes: #108