termenv: add shim for js #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports GOOS=js GOARCH=wasm go build Signed-off-by: Christian Stewart <christian@paral.in>
|
That seems reasonable. Thank you! |
|
Why would the foreground color not default to ANSI color 15, which is white? I guess it doesn't matter much overall, but gray seems like a strange default. Is there some history there I'm unaware of? |
|
@makeworld-the-better-one Historically speaking it has always(?) been ANSI 7, at least on Linux, DOS, Windows, *BSD. |
|
Fwiw the xterm.js background defaults to dark gray. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports GOOS=js GOARCH=wasm go build