Add 'kitty' and 'ansi' values as a fallback color support detection #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarlos0
approved these changes
Jan 31, 2022
Comment on lines
+44
to
+46
| if strings.Contains(term, "ansi") { | ||
| return ANSI | ||
| } |
There was a problem hiding this comment.
I think this could be in the switch case above... as the string seems to be exactly ansi
There was a problem hiding this comment.
Yeah, had the same thought at first, but moved it down eventually: if it's foobar-ansi, it's probably still correct to assume it's supporting ANSI colors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ansibeing an option for macOS Terminal,kittysometimes comes without aCOLORTERMenv var being set.