[icons] New iteration

[oliviertassinari]

Speed up the google icons scrapping script and makes it more reliable.

[mbrookes]

Not even going to attempt to review your code 😄, but it's working great, and looks like a great improvement! 🚀

[mbrookes]

lol

[oliviertassinari]

I'm reverting the demo. It's significantly slowing everything down. I'm gonna keep it commented so we can use it to debug.

[eddiemonge]

Maybe this should have had a review. Why was babel runtime added as a dependency of Icons? c7cc6a8#diff-3166425e4a7cf7143755bf476e42250fR45

[oliviertassinari]

@eddiemonge Because we use @babel/plugin-transform-runtime. Is that an issue?

[eps1lon]

@oliviertassinari See #13220

[oliviertassinari]

Ugh. That is so dirty. The babel runtime transform should be adding that code itself instead of requiring another package.

@eddiemonge What's wrong in that?

A plugin that enables the re-use of Babel's injected helper code to save on codesize.

https://babeljs.io/docs/en/babel-plugin-transform-runtime