[Slider] Fix failing handler test #12535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
fix-slider-tests
branch
from
3f0eedc to
dae017d
Compare
|
@eps1lon Thanks for working on this! Please could you run |
See https://github.com/airbnb/enzyme/blob/master/docs/api/ShallowWrapper/simulate.md#common-gotchas for why we need to simulate events on the wrapper.
eps1lon
force-pushed
the
fix-slider-tests
branch
from
dae017d to
6931f87
Compare
|
This was fixed as a side-effect of #12538. I just rebased master onto this. |
|
@eps1lon Thanks! |
oliviertassinari
changed the title
This was referenced Mar 26, 2020
oliviertassinari
added
component: slider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes mostly changes that handle
enzyme#simulategotchas. I also removed the mousedownhandler from the button since it seemed redundant.See https://github.com/airbnb/enzyme/blob/master/docs/api/ShallowWrapper/simulate.md#common-gotchas for why we need to simulate events on the wrapper.
Errors were introduced in #11889
Fixes one error surfaced in #12531