[Slider] Fix transitions #12531
Merged
[Slider] Fix transitions #12531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI errors seem to be unrelated because CI did not run on some PRs that introduced errors (e.g. #12244). I'm working on fixes to those errors. |
This was referenced Aug 15, 2018
Fixes track behavior when slider was focused and values were changed via arrow keys. The track used to outspace the thumb.
eps1lon
force-pushed
the
fix-slider-transitions
branch
from
7bab10b to
692c85b
Compare
|
Rebased with master to fix the unrelated issues. PR is ready for review. I hope the gifs illustrate the issue sufficiently. |
|
@eps1lon Thanks! |
marcelpanse
pushed a commit
to marcelpanse/material-ui
that referenced
this pull request
Oct 2, 2018
Fixes track behavior when slider was focused and values were changed via arrow keys. The track used to outspace the thumb.
oliviertassinari
added
bug 🐛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior when focusing the slider and changing values via arrow key:
before (actual):
after (expect/on this branch):
This also fixes inconsistent transition behavior for the box-shadow and resizing of the thumb i.e. no transition on mousedown but a transition on mouseup.