Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popover] Fix position when changing state or updated #19046

Merged
merged 3 commits into from
Dec 31, 2019
Merged

[Popover] Fix position when changing state or updated #19046

merged 3 commits into from
Dec 31, 2019

Conversation

SandraMarcelaHerreraArriaga
Copy link
Contributor

@SandraMarcelaHerreraArriaga SandraMarcelaHerreraArriaga commented Dec 30, 2019 •
edited by oliviertassinari
Loading

Closes #10595

Apply the same patch as #18813.

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 30, 2019 •
edited
Loading

Details of bundle changes.

Comparing: d332339...cc7e57d

bundle Size Change Size Gzip Change Gzip
@material-ui/core[umd] ▲ +25 B (+0.01% ) 314 kB ▼ -9 B (-0.01% ) 90.6 kB
@material-ui/core ▲ +20 B (+0.01% ) 358 kB ▼ -11 B (-0.01% ) 97.7 kB
Popover ▲ +20 B (+0.02% ) 82.5 kB ▲ +9 B (+0.04% ) 25.7 kB
TextField ▲ +20 B (+0.02% ) 123 kB ▼ -8 B (-0.02% ) 36.1 kB
docs.main ▲ +20 B (0.00% ) 614 kB ▲ +5 B (0.00% ) 196 kB
Menu ▲ +20 B (+0.02% ) 88.2 kB ▲ +5 B (+0.02% ) 27.3 kB
TablePagination ▲ +20 B (+0.01% ) 141 kB ▼ -4 B (-0.01% ) 41.3 kB
Select ▲ +20 B (+0.02% ) 114 kB ▼ -2 B (-0.01% ) 34 kB
@material-ui/lab -- 177 kB -- 53.4 kB
@material-ui/styles -- 50.8 kB -- 15.3 kB
@material-ui/system -- 14.5 kB -- 4.04 kB
AppBar -- 63.7 kB -- 20 kB
Autocomplete -- 129 kB -- 40.4 kB
Avatar -- 65 kB -- 20.6 kB
AvatarGroup -- 62 kB -- 19.5 kB
Backdrop -- 67.5 kB -- 20.9 kB
Badge -- 65.1 kB -- 20.3 kB
BottomNavigation -- 62.2 kB -- 19.5 kB
BottomNavigationAction -- 75.2 kB -- 23.8 kB
Box -- 70.5 kB -- 21.5 kB
Breadcrumbs -- 67.7 kB -- 21.3 kB
Button -- 79.4 kB -- 24.4 kB
ButtonBase -- 73.7 kB -- 23.2 kB
ButtonGroup -- 82.9 kB -- 25.5 kB
Card -- 62.6 kB -- 19.6 kB
CardActionArea -- 74.8 kB -- 23.6 kB
CardActions -- 61.8 kB -- 19.4 kB
CardContent -- 61.7 kB -- 19.4 kB
CardHeader -- 64.8 kB -- 20.5 kB
CardMedia -- 62.1 kB -- 19.6 kB
Checkbox -- 81.7 kB -- 25.9 kB
Chip -- 82.3 kB -- 25.3 kB
CircularProgress -- 63.9 kB -- 20.2 kB
ClickAwayListener -- 3.85 kB -- 1.55 kB
Collapse -- 67.6 kB -- 21 kB
colorManipulator -- 3.85 kB -- 1.52 kB
Container -- 63 kB -- 19.8 kB
CssBaseline -- 57.3 kB -- 18 kB
Dialog -- 82.5 kB -- 25.8 kB
DialogActions -- 61.9 kB -- 19.5 kB
DialogContent -- 62 kB -- 19.5 kB
DialogContentText -- 63.8 kB -- 20.1 kB
DialogTitle -- 64 kB -- 20.1 kB
Divider -- 62.3 kB -- 19.7 kB
docs.landing -- 50.7 kB -- 13.4 kB
Drawer -- 84.2 kB -- 25.7 kB
ExpansionPanel -- 71.1 kB -- 22.3 kB
ExpansionPanelActions -- 61.8 kB -- 19.4 kB
ExpansionPanelDetails -- 61.7 kB -- 19.4 kB
ExpansionPanelSummary -- 77.8 kB -- 24.6 kB
Fab -- 76.5 kB -- 23.9 kB
Fade -- 23.3 kB -- 8 kB
FilledInput -- 73.3 kB -- 22.8 kB
FormControl -- 64.1 kB -- 20 kB
FormControlLabel -- 65.3 kB -- 20.5 kB
FormGroup -- 61.8 kB -- 19.4 kB
FormHelperText -- 63 kB -- 19.8 kB
FormLabel -- 63.2 kB -- 19.7 kB
Grid -- 64.9 kB -- 20.4 kB
GridList -- 62.2 kB -- 19.6 kB
GridListTile -- 63.5 kB -- 20 kB
GridListTileBar -- 63 kB -- 19.8 kB
Grow -- 23.9 kB -- 8.2 kB
Hidden -- 65.7 kB -- 20.7 kB
Icon -- 62.5 kB -- 19.7 kB
IconButton -- 75.9 kB -- 23.7 kB
Input -- 72.2 kB -- 22.6 kB
InputAdornment -- 64.8 kB -- 20.5 kB
InputBase -- 70.3 kB -- 22.1 kB
InputLabel -- 65.1 kB -- 20.1 kB
LinearProgress -- 65.1 kB -- 20.4 kB
Link -- 66.4 kB -- 21 kB
List -- 62.1 kB -- 19.4 kB
ListItem -- 76.8 kB -- 24.1 kB
ListItemAvatar -- 61.9 kB -- 19.4 kB
ListItemIcon -- 61.9 kB -- 19.4 kB
ListItemSecondaryAction -- 61.8 kB -- 19.4 kB
ListItemText -- 64.7 kB -- 20.4 kB
ListSubheader -- 62.5 kB -- 19.7 kB
MenuItem -- 77.9 kB -- 24.4 kB
MenuList -- 65.7 kB -- 20.6 kB
MobileStepper -- 67.6 kB -- 21.3 kB
Modal -- 14.3 kB -- 5.01 kB
NativeSelect -- 76.6 kB -- 24.2 kB
NoSsr -- 2.19 kB -- 1.04 kB
OutlinedInput -- 73.7 kB -- 23 kB
Paper -- 62.1 kB -- 19.4 kB
Popper -- 28.7 kB -- 10.3 kB
Portal -- 2.9 kB -- 1.3 kB
Radio -- 82.7 kB -- 26.2 kB
RadioGroup -- 63.2 kB -- 19.9 kB
Rating -- 70 kB -- 22.6 kB
RootRef -- 4.21 kB -- 1.64 kB
Skeleton -- 62.7 kB -- 19.9 kB
Slide -- 25.3 kB -- 8.72 kB
Slider -- 75.3 kB -- 23.9 kB
Snackbar -- 74.9 kB -- 23.5 kB
SnackbarContent -- 63.3 kB -- 20 kB
SpeedDial -- 85.8 kB -- 27.1 kB
SpeedDialAction -- 117 kB -- 37 kB
SpeedDialIcon -- 64.3 kB -- 20.2 kB
Step -- 62.4 kB -- 19.6 kB
StepButton -- 82 kB -- 26 kB
StepConnector -- 62.5 kB -- 19.7 kB
StepContent -- 68.8 kB -- 21.6 kB
StepIcon -- 64.4 kB -- 20.1 kB
StepLabel -- 68.3 kB -- 21.2 kB
Stepper -- 64.6 kB -- 20.4 kB
styles/createMuiTheme -- 16.5 kB -- 5.84 kB
SvgIcon -- 62.8 kB -- 19.7 kB
SwipeableDrawer -- 91.6 kB -- 28.7 kB
Switch -- 80.9 kB -- 25.6 kB
Tab -- 76.1 kB -- 24.1 kB
Table -- 62.3 kB -- 19.6 kB
TableBody -- 61.9 kB -- 19.4 kB
TableCell -- 63.8 kB -- 20.2 kB
TableContainer -- 61.7 kB -- 19.4 kB
TableFooter -- 61.9 kB -- 19.4 kB
TableHead -- 61.9 kB -- 19.4 kB
TableRow -- 62.3 kB -- 19.6 kB
TableSortLabel -- 77.1 kB -- 24.3 kB
Tabs -- 85.2 kB -- 27.1 kB
TextareaAutosize -- 5.09 kB -- 2.14 kB
ToggleButton -- 75.9 kB -- 24.1 kB
ToggleButtonGroup -- 63 kB -- 19.9 kB
Toolbar -- 62.1 kB -- 19.6 kB
Tooltip -- 101 kB -- 31.9 kB
TreeItem -- 73.5 kB -- 23.3 kB
TreeView -- 66.1 kB -- 20.8 kB
Typography -- 63.4 kB -- 19.9 kB
useAutocomplete -- 12.7 kB -- 4.71 kB
useMediaQuery -- 2.5 kB -- 1.06 kB
Zoom -- 23.4 kB -- 8.11 kB

Generated by 🚫 dangerJS against cc7e57d

@SandraMarcelaHerreraArriaga SandraMarcelaHerreraArriaga changed the title add useImperativeHandler and move some setPositioningStyles and addev… Popover-Reposition-when-rerender-#10595 Dec 30, 2019
@SandraMarcelaHerreraArriaga SandraMarcelaHerreraArriaga changed the title Popover-Reposition-when-rerender-#10595 Popover-Reposition-when-rerender Dec 30, 2019
@oliviertassinari oliviertassinari added the component: Popover The React component. label Dec 31, 2019
@oliviertassinari oliviertassinari changed the title Popover-Reposition-when-rerender [Popover] Reposition when render Dec 31, 2019
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Dec 31, 2019
@oliviertassinari oliviertassinari changed the title [Popover] Reposition when render [Popover] Fix position when changing state or updated Dec 31, 2019
@oliviertassinari oliviertassinari force-pushed the Popover-Reposition-when-rerender-#10595 branch from 36756a9 to cc7e57d Compare December 31, 2019 10:41
@oliviertassinari oliviertassinari merged commit f38c262 into mui:master Dec 31, 2019
@oliviertassinari
Copy link
Member

@SandraMarcelaHerreraArriaga thanks

@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 16, 2020
Merged
@tpeek tpeek mentioned this pull request Apr 25, 2020
Closed
2 tasks
@michaldudak michaldudak mentioned this pull request Oct 11, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: Popover The React component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Popover] Reposition when rerender
3 participants
@SandraMarcelaHerreraArriaga @mui-pr-bot @oliviertassinari