Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popover] Use different transition event for style calculation #34662

Closed

Conversation

vanyaxk
Copy link
Contributor

@vanyaxk vanyaxk commented Oct 8, 2022

Fixes #34236 by changing event for style calculation, also removed an effect to avoid unnecessary reflows, as the transition event callback handles it well enough

@mui-bot
Copy link

mui-bot commented Oct 8, 2022

Details of bundle changes

Generated by 🚫 dangerJS against 9dd62a9

@michaldudak michaldudak changed the title fix(popover): use different transition event for style calculation [Popover] Use different transition event for style calculation Oct 11, 2022
@michaldudak michaldudak added bug 🐛 Something doesn't work component: Popover The React component. package: material-ui Specific to @mui/material labels Oct 11, 2022
@michaldudak
Copy link
Member

Thanks for your contribution!
This fixes the problem indeed but also restores the problem described in #10595 and fixed in #19046. We need to update the position of the Popover when Select's options change. I'm not saying the previous solution was the best one (it sets the position on every update), so perhaps there's a better way to do it.

@michaldudak
Copy link
Member

There's another PR that seems not to introduce (or bring back) any regressions: #34546. We're likely going to proceed with that one. Thanks for your work anyway and I'm looking forward to seeing more contributions from you :)

@vanyaxk vanyaxk deleted the fix/popover-style-calculation-logic branch October 16, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: Popover The React component. package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Select] dropdown opens up and then down (flickers)
3 participants