Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

views prop does not work with InlineDatePicker #925

Closed
bhgoal opened this issue Feb 22, 2019 · 2 comments
Closed

views prop does not work with InlineDatePicker #925

bhgoal opened this issue Feb 22, 2019 · 2 comments

Comments

@bhgoal
Copy link

bhgoal commented Feb 22, 2019

A GIF or MEME to give some spice of the internet

Environment

Tech Version
material-ui-pickers 2.2.1
material-ui 3.7.0
React 16.6.3
Browser Chrome
Peer library date-fns

Steps to reproduce

  1. Create InlineDatePicker component
  2. Pass prop 'view={['year', 'month']}

Expected behavior

Inline datepicker appears, opened to Months.

Actual behavior

Inlinedatepicker appears, opened to Days.
Works without issue when using DatePicker, but not InlineDatePicker

@sergey-siuchanka
Copy link

Same issue for material-ui: 3.8.3 and react: 16.7.0.

@sergey-siuchanka
Copy link

Also reproduced here https://codesandbox.io/s/zrql0n958m.

dmtrKovalenko added a commit that referenced this issue Mar 1, 2019
* [#925] [#930] Support views and openTo props for InlineDatePicker

* [#929] Fix openTo prop always recognizing as year
dmtrKovalenko added a commit that referenced this issue Mar 1, 2019
* [#925] [#930] Support views and openTo props for InlineDatePicker

* [#929] Fix openTo prop always recognizing as year

* [#925] Rerun getDisplayDate on labelFunc change
dmtrKovalenko added a commit that referenced this issue Mar 1, 2019
* [#925] [#930] Support views and openTo props for InlineDatePicker

* [#929] Fix openTo prop always recognizing as year

* [#925] Rerun getDisplayDate on labelFunc change

* Add onMonthChange and onYearChange callbacks

* Pass new callbacks also for DateTimePicker

* Move firing onYearChange to YearSelection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants