Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TimePicker] Fix time position in landscape orientation #1224

Merged
merged 3 commits into from
Aug 4, 2019

Conversation

dmtrKovalenko
Copy link
Member

This PR closes #1197

@dmtrKovalenko dmtrKovalenko changed the title Bugfix/landscape align ampm [TimePicker] Fix time position in landscape orientation Aug 2, 2019
@cypress
Copy link

cypress bot commented Aug 2, 2019



Test summary

50 0 0 0


Run details

Project material-ui-pickers
Status Passed
Commit 365d09b
Started Aug 4, 2019 8:09 AM
Ended Aug 4, 2019 8:12 AM
Duration 02:09 💡
OS Linux Debian - 8.11
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #1224 into next will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##            next    #1224      +/-   ##
=========================================
- Coverage   94.2%   94.13%   -0.07%     
=========================================
  Files         56       56              
  Lines       1414     1415       +1     
  Branches     199      200       +1     
=========================================
  Hits        1332     1332              
- Misses        64       65       +1     
  Partials      18       18
Impacted Files Coverage Δ
lib/src/TimePicker/TimePickerToolbar.tsx 95.65% <100%> (+0.09%) ⬆️
lib/src/views/Clock/ClockPointer.tsx 92% <0%> (-4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd75e9...365d09b. Read the comment docs.

@dmtrKovalenko dmtrKovalenko merged commit 3048401 into next Aug 4, 2019
@dmtrKovalenko dmtrKovalenko deleted the bugfix/landscape-align-ampm branch August 4, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Landscape time picker: Time not centered in 24h mode
1 participant