[a11y] Open picker by space/enter click #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmtrKovalenko
changed the title
|
Wait, enter? You sure about this? Enter is used to send forms. Isn't it the case? |
|
@TrySound yeah you are right, but it should also open the interactive controls? Shouldn't it? Yeah, but actually we can left only space |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Mixing behaviours is confusing IMO |
Codecov Report
@@ Coverage Diff @@
## next #1266 +/- ##
=========================================
+ Coverage 93.9% 94.01% +0.11%
=========================================
Files 55 56 +1
Lines 1345 1420 +75
Branches 198 201 +3
=========================================
+ Hits 1263 1335 +72
- Misses 64 67 +3
Partials 18 18
Continue to review full report at Codecov.
|
|
Only space :) |
kizzetipong
added a commit
to kizzetipong/material-ui-thai-datepickers
that referenced
this pull request
Aug 30, 2019
* newdev: (671 commits) Re-implement based from v3.2.4 - fix issue yyyy case sensitive / unexpected TODO from year selector v3.2.4 Restore support of lib instnace (mui#1281) Fix ts error and formik example (mui#1280) v3.2.3 Update patrons list Add mention of renamed `moment` property (mui#1268) [a11y] Open picker by space click (mui#1266) Do not allow input any chars when value is nul (mui#1265) Dispatch onChange before onClose (mui#1264) Refactor wrapping <Picker /> in state to be 1 component (mui#1263) [InlineWrapper]: Don't force any width on the paper (mui#1248) (mui#1261) Remove direct `@material-ui/core` imports. (mui#1252) [docs] Fix typo in date-fns localization title Fix direct @material-ui/core imports (mui#1236) Update prop-types.json Ovveride keyboard datepicker onChange date type [docs] Show DateIOType instead of anys (mui#1228) Update release script v3.2.2 ... # Conflicts: # README.md # docs/src/Examples/Demo/DatePicker/BasicDatePicker.jsx # docs/src/Examples/Demo/DatePicker/InlineDatePicker.jsx # docs/src/Examples/Demo/DateTimePicker/BasicDateTimePicker.jsx # docs/src/Examples/Demo/DateTimePicker/InlineDateTimePicker.jsx # lib/package.json # lib/src/DatePicker/DatePicker.jsx # lib/src/DatePicker/DatePickerInline.jsx # lib/src/DatePicker/DatePickerModal.jsx # lib/src/DatePicker/components/Calendar.jsx # lib/src/DatePicker/components/CalendarHeader.jsx # lib/src/DatePicker/components/YearSelection.jsx # lib/src/DateTimePicker/DateTimePicker.jsx # lib/src/DateTimePicker/DateTimePickerInline.jsx # lib/src/DateTimePicker/DateTimePickerModal.jsx # lib/src/DateTimePicker/components/DateTimePickerHeader.jsx # lib/src/_shared/DateTextField.jsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1059 and resolves #1231
Also contains all changes from, so fixes #1253
Description
Open picker by space/enter click