(chore) Better material-ui core components import strategy

[oliviertassinari]

• Fix
• Import one level deep to speed-up bundling

[vercel]

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/mui-org/material-ui-pickers/5zvv1qf67
✅ Preview: https://material-ui-pi-git-fork-oliviertassinari-fix-external-de-92e489.mui-org.now.sh

[oliviertassinari]

To investigate if we can't get rid of this module. However, without the bundle size tracking tool of the core repository, it might be a bit challenging to measure progress on the impact.

[dmtrKovalenko]

Wouldn’t core imports be treeshaked even when mixed?

[oliviertassinari]

Wouldn’t core imports be treeshaked even when mixed

They are.

The motivation is not to force a choice on the users regarding https://material-ui.com/guides/minimizing-bundle-size/#development-environment.

[oliviertassinari]

Code style issues found in the above file(s). Forgot to run Prettier?

How can I run Prettier (my IDE doesn't support it)?

[dmtrKovalenko]

Something broken with latest husky release. For some reason precommit hooks don’t work even for me 🤷‍♂️

[oliviertassinari]

On the core repository, we have yarn prettier, but I'm not sure what to use here 😁. Plus, there is no visual error output I can use to patch it by hand.

[oliviertassinari]

For some reason precommit hooks don’t work even for me

It does run on my side, I wish it didn't run actually, it's frustrating me to have to wait a couple of seconds to be able to commit.

[codecov]

Codecov Report

Merging #1590 into next will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next    #1590      +/-   ##
==========================================
+ Coverage   92.02%   92.07%   +0.04%     
==========================================
  Files          64       64              
  Lines        1781     1791      +10     
  Branches      307      307              
==========================================
+ Hits         1639     1649      +10     
  Misses        108      108              
  Partials       34       34

Impacted Files	Coverage Δ
lib/src/_shared/ToolbarText.tsx	100% <ø> (ø)	⬆️
lib/src/views/Clock/ClockPointer.tsx	100% <ø> (ø)	⬆️
lib/src/wrappers/MobileWrapper.tsx	100% <ø> (ø)	⬆️
lib/src/_shared/PureDateInput.tsx	100% <ø> (ø)	⬆️
lib/src/views/Calendar/Year.tsx	96.77% <100%> (ø)	⬆️
lib/src/views/Calendar/CalendarView.tsx	82.5% <100%> (+0.44%)	⬆️
lib/src/views/MobileKeyboardInputView.tsx	45.45% <100%> (ø)	⬆️
lib/src/_shared/ToolbarButton.tsx	100% <100%> (ø)	⬆️
lib/src/views/Calendar/CalendarHeader.tsx	91.66% <100%> (+0.14%)	⬆️
lib/src/views/Clock/ClockNumber.tsx	94.28% <100%> (ø)	⬆️
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eac5818...9416133. Read the comment docs.