Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DateRangePicker] Introduce new component 🎉 #1602
[DateRangePicker] Introduce new component 🎉 #1602
Changes from all commits
071c86a
6278df7
70ad657
c3e90c9
09e701d
88489b5
c72bc5f
eb95e4d
f19294a
a6f90a5
beb6f39
3dc7bba
300bb03
e855363
b8bfdff
c10707e
6af2269
b1dd4d6
f0960dd
61341c6
9d02640
71c6754
3bea358
b7e7a75
6a606f3
99978af
b87ddc2
983301f
b279d92
1fc147e
bc1344b
91e1ede
4930936
d08fa22
164f12f
0776828
5deb7da
50801c2
3b17556
e313edd
30c88f3
c1b0b7b
10681c8
402f6d6
e287d32
6b17816
172c240
a827fd2
f2b31b1
6802795
4b8173b
fc6f92c
78a75df
91ba76a
23c600c
12c0baa
402e7f2
e9a7c16
9a2a75f
838a71c
eadb5f0
6aee13e
9fa0a0a
097ec56
2e13670
573cc57
a9fd7ac
8865fcf
e440de3
e86fb22
e7f2f44
1a35fd3
29191fc
f2e89b1
12d5064
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't work in people's codebases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, but only one thing we can do without dramatically changes in examples - add warning comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it won't be the only issue. Doesn't
DateRangePicker
has a required context that we should problem?I think that we will need to have a dedicated story for this. It's important all the demos can be copied and paste without any exceptions. It hasn't always been the case in the core repository, it has been painful for developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, this is require to interop with different libraries.
Ideally we need separate demo for each lib (maybe somehow generated as we are doing for formats)