Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align DateRangePicker inputs by baseline #1689

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Conversation

Philipp91
Copy link
Contributor

In particular, this affects the positioning of the "to" in between the two boxes. It doesn't make a difference when the pickers use outlined styling (like in the demo), but it does fix the positioning with the standard styling.

In particular, this affects the positioning of the "to" in between the two boxes. It doesn't make a difference when the pickers use outlined styling (like in the demo), but it does fix the positioning with the standard styling.
@vercel
Copy link

vercel bot commented Apr 19, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/mui-org/material-ui-pickers/542mn0nj0
✅ Preview: https://material-ui-pickers-git-fork-philipp91-patch-5.mui-org.now.sh

@codecov
Copy link

codecov bot commented Apr 19, 2020

Codecov Report

Merging #1689 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1689   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files          73       73           
  Lines        2315     2315           
  Branches      402      402           
=======================================
  Hits         2078     2078           
  Misses        190      190           
  Partials       47       47           
Impacted Files Coverage Δ
lib/src/DateRangePicker/DateRangePickerInput.tsx 69.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70bb56f...e155d2f. Read the comment docs.

@dmtrKovalenko dmtrKovalenko merged commit 14e076f into mui:next Apr 20, 2020
@dmtrKovalenko
Copy link
Member

@Philipp91 Could you please give more context? I don't like the new appearance. XD

image

@Philipp91
Copy link
Contributor Author

Whoops. Maybe I adjusted the wrong field? Here is what I was trying to fix:
image

This PR was untested, also it doesn't reproduce in the demo because the demo uses outlined text fields.

@dmtrKovalenko
Copy link
Member

The problem is for mobile displaying. Check from any mobile device.

Philipp91 added a commit to Philipp91/material-ui-pickers that referenced this pull request Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants