Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DatePicker] Add test for textbox aria-invalid #1955

Merged
merged 7 commits into from
Jul 31, 2020

Conversation

PaulSavignano
Copy link
Contributor

@PaulSavignano PaulSavignano commented Jul 4, 2020

@vercel
Copy link

vercel bot commented Jul 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/7j4y5wbne
✅ Preview: https://material-ui-pi-git-fork-paulsavignano-test-datepickertes-1e0c6f.mui-org.vercel.app

@cypress
Copy link

cypress bot commented Jul 4, 2020



Test summary

78 0 3 0


Run details

Project material-ui-pickers
Status Passed
Commit cf31b5c
Started Jul 31, 2020 12:06 PM
Ended Jul 31, 2020 12:08 PM
Duration 01:34 💡
OS Linux Debian - 10.0
Browser Chrome 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this test case is definitely nice to have. Added a couple of comments how to make tests more readable.

lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved
lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved
lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start :)

lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved
lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved
lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved
lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved
lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved
@dmtrKovalenko
Copy link
Member

Am I the only who cannot see the changes of this PR?
image

@PaulSavignano
Copy link
Contributor Author

@dmtrKovalenko, During a revert to an earlier commit my local git became out of sync and would not pull in changes from the next branch. I was unable to merge and ran a reset.

While running tests with luxon and moment the test for valid after invalid fails with locale de. I can look into this further if you'd like.

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a few comments, we are almost there :).

lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved
lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved
lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved
lib/src/__tests__/test-utils.tsx Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari force-pushed the test/DatePickerTestingLib branch from 60429fc to 571a2a5 Compare July 30, 2020 15:06
@oliviertassinari oliviertassinari changed the title test: add tests for locale updates [DatePicker] Add test for textbox aria-invalid Jul 30, 2020
@vercel vercel bot temporarily deployed to Preview July 30, 2020 15:10 Inactive
@oliviertassinari oliviertassinari force-pushed the test/DatePickerTestingLib branch from 5ff363b to 717ffd3 Compare July 30, 2020 15:11
@vercel vercel bot temporarily deployed to Preview July 30, 2020 15:11 Inactive
@oliviertassinari oliviertassinari force-pushed the test/DatePickerTestingLib branch from 717ffd3 to 667397e Compare July 30, 2020 15:11
@vercel vercel bot temporarily deployed to Preview July 30, 2020 15:12 Inactive
@@ -60,7 +60,7 @@
"test": "jest",
"test:typescript": "yarn rimraf src/__tests__/dist && tsc -p src/__tests__/tsconfig.json",
"test:date-fns": "UTILS=date-fns yarn test",
"test:dayjs": "UTILS=datejs yarn test",
"test:dayjs": "UTILS=dayjs yarn test",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmtrKovalenko Dayjs tests were running with date-fns

@vercel vercel bot temporarily deployed to Preview July 30, 2020 16:41 Inactive
@oliviertassinari oliviertassinari force-pushed the test/DatePickerTestingLib branch from 28b8469 to 55976a5 Compare July 30, 2020 16:41
Copy link
Member

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this awesome tests!

lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants