Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix inputRef date picker customization demo #2028

Merged
merged 2 commits into from
Jul 27, 2020
Merged

[docs] Fix inputRef date picker customization demo #2028

merged 2 commits into from
Jul 27, 2020

Conversation

Chee7ah
Copy link
Contributor

@Chee7ah Chee7ah commented Jul 23, 2020

Fixes Issue #2027.

Applying the inputRef instead of ref to the <input /> component in the demo fixes the issue of the picker closing prematurely after a single date pick instead of waiting for both dates of the range to be picked.

@vercel
Copy link

vercel bot commented Jul 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/l1c5mfy09
✅ Preview: https://material-ui-pickers-git-fork-chee7ah-patch-1.mui-org.vercel.app

@cypress
Copy link

cypress bot commented Jul 23, 2020



Test summary

78 0 3 0


Run details

Project material-ui-pickers
Status Passed
Commit d727761
Started Jul 23, 2020 10:08 AM
Ended Jul 23, 2020 10:10 AM
Duration 01:30 💡
OS Linux Debian - 10.0
Browser Chrome 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@oliviertassinari
Copy link
Member

If we are going to fix the demo, I wonder if we shouldn't move forward with this approach at the same time: https://material-ui.com/components/autocomplete/#customizations - #1768. Maybe it will avoid us to break the demo a second time.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 23, 2020

What about we leverage the focused variable for the custom input demo? I think that it's an important UX element developers and designers need to be aware of.

@oliviertassinari oliviertassinari changed the title Update ref to inputRef on the broken demo [docs] Fix inputRef date picker customization demo Jul 23, 2020
@dmtrKovalenko dmtrKovalenko merged commit b101c47 into mui:next Jul 27, 2020
@Chee7ah Chee7ah deleted the patch-1 branch July 28, 2020 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants