Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update date on blur #350

Merged
merged 8 commits into from
May 31, 2018
Merged

Update date on blur #350

merged 8 commits into from
May 31, 2018

Conversation

LastDreamer
Copy link
Contributor

@LastDreamer LastDreamer commented Apr 11, 2018 •
edited
Loading

  • I have changed my target branch to develop 👊

@LastDreamer LastDreamer mentioned this pull request Apr 11, 2018
Closed
@cherniavskii
Copy link
Member

Hi Oleg,
sorry for taking so long to take a look on your PR.

Can you add a description of changes / approach?
It will help us to review it and hopefully push it forward

@LastDreamer
Copy link
Contributor Author

LastDreamer commented Apr 29, 2018 •
edited
Loading

My changes do following things:

  • not apply changes during keyboard input
  • apply changes on press "Enter" if props.disableOpenOnEnter is true
  • apply changes on blur event if fired by input (not calendar icon)
  • gives new prop parseFormats for possibility input date with not full format. For example display format is "MM/DD/YYYY hh:mm", and parse formats is ["MM/DD/YYYY hh:mm", "MM/DD/YYYY"] - we cat type "04/29/2018" and it will be valid date

@LastDreamer
Copy link
Contributor Author

Anything else?

@dmtrKovalenko
Copy link
Member

@LastDreamer where is my last comment 🤔? Sorry if thats my fault.
So I'm aware of logic for multiple parse formats as well as reducing logic to find the format.
I will merge the PR if you will rollback everything related to parseFormat prop.

@dmtrKovalenko dmtrKovalenko added the important Need work label May 11, 2018
@dmtrKovalenko dmtrKovalenko self-assigned this May 11, 2018
@LastDreamer LastDreamer changed the title Update date on blur and multiple formats for valid date parsing [WIP - don't merge] Update date on blur and multiple formats for valid date parsing May 22, 2018
@LastDreamer LastDreamer changed the title [WIP - don't merge] Update date on blur and multiple formats for valid date parsing Update date on blur May 22, 2018
@LastDreamer
Copy link
Contributor Author

done

@dmtrKovalenko dmtrKovalenko merged commit d039442 into mui:develop May 31, 2018
@dmtrKovalenko
Copy link
Member

I am sorry for so long reviewing. I was on vacation 🌴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dmtrKovalenko dmtrKovalenko

Labels
important Need work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LastDreamer @cherniavskii @dmtrKovalenko